Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump golanci-lint action #1453

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: bump golanci-lint action #1453

merged 1 commit into from
Nov 11, 2024

Conversation

psturc
Copy link
Member

@psturc psturc commented Nov 11, 2024

TTSIA

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@psturc psturc force-pushed the bump-golangcilint-version branch from cbac471 to fb75a54 Compare November 11, 2024 13:39
@psturc psturc marked this pull request as ready for review November 11, 2024 13:44
@openshift-ci openshift-ci bot requested review from dheerajodha and pmacik November 11, 2024 13:44
jhutar
jhutar approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhutar
Once this PR has been reviewed and has the lgtm label, please ask for approval from psturc. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc psturc merged commit bb61356 into konflux-ci:main Nov 11, 2024
8 of 10 checks passed
@psturc psturc deleted the bump-golangcilint-version branch November 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhutar jhutar jhutar approved these changes

@dheerajodha dheerajodha Awaiting requested review from dheerajodha

@pmacik pmacik Awaiting requested review from pmacik

Assignees

@jhutar jhutar

Labels
lgtm < 1 min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psturc @jhutar