Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove references to jvm-build-service #1478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove references to jvm-build-service #1478

wants to merge 1 commit into from
+15 −732

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Dec 12, 2024 •
edited
Loading

Description

Issue ticket number and link

STONEBLD-3015

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from jinqi7 and rcerven December 12, 2024 19:29
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 8449f48 to c993e0d Compare December 13, 2024 12:32
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mmorhun
Once this PR has been reviewed and has the lgtm label, please assign flacatus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnevrlka
Copy link
Contributor Author

/retest

1 similar comment
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from c993e0d to f8af801 Compare December 19, 2024 16:04
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch 2 times, most recently from a18243a to 1f206c4 Compare January 8, 2025 12:30
@tnevrlka
Copy link
Contributor Author

tnevrlka commented Jan 8, 2025

/retest

1 similar comment
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka
chore: remove references to jvm-build-service
29f4f1d 
- jvm-build-service is currently not being used by anyone
- It is going to undergo major breaking changes and is going to be
  removed for now until the changes are done
- Current tests are probably going to be useless due to the rewrite
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 1f206c4 to 29f4f1d Compare January 20, 2025 08:56
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

@tnevrlka: The following commands are available to trigger required jobs:

/test images

/test load-test-ci-100u

/test load-test-ci-10u

/test load-test-ci-1u

/test load-test-ci-50u

/test load-test-ci-50u-realworld

/test load-test-max-concurrency-realworld

/test max-concurrency

The following commands are available to trigger optional jobs:

/test redhat-appstudio-e2e

Use /test all to run the following jobs that were automatically triggered:

pull-ci-konflux-ci-e2e-tests-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tnevrlka
Copy link
Contributor Author

/ok-to-test

@tnevrlka
Copy link
Contributor Author

/retest

2 similar comments
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka
Copy link
Contributor Author

/retest

tisutisu
tisutisu reviewed Jan 21, 2025
View reviewed changes
magefiles/magefile.go
@@ -429,90 +429,6 @@ func setRequiredEnvVars() error {
envVarPrefix = "INTEGRATION_SERVICE"
imageTagSuffix = "integration-service-image"
testSuiteLabel = "integration-service"
case strings.Contains(jobName, "jvm-build-service"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to remove these jobs using this part of the code? I think they might start failing after we merge this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisutisu tisutisu tisutisu left review comments

@mmorhun mmorhun mmorhun approved these changes

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@rcerven rcerven Awaiting requested review from rcerven

Assignees
No one assigned
Labels
10-15 min ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnevrlka @tisutisu @mmorhun