Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-5718): fix afterall to close merge request even it failed #1490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kasemAlem
Copy link
Contributor

@kasemAlem kasemAlem commented Jan 21, 2025

On the Gitlab repo used to run the gitlab e2e-test suite , merge requests were not closed
as expected on the tear down of test , we fixed it by :

  • Close the opened MRs
  • Fix the AfterAll function so the MR will be closed even when test failed

Expected :
once we merge this fix we expect that no more old MRs opened

KONFLUX-5718

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Signed-off-by: Kasem Alem <kalem@kalem-thinkpadp16vgen1.raanaii.csb>
@konflux-ci-qe-bot
Copy link

@kasemAlem: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-4x5tt Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-4x5tt

Test results analysis

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

➡️ [failed] [It] [integration-service-suite Gitlab Status Reporting of Integration tests] Gitlab with status reporting of Integration tests in the assosiated merge request when Integration PipelineRun is created eventually leads to the integration test PipelineRun's Fail status reported at MR notes [integration-service, gitlab-status-reporting]

Click to view logs

Unexpected error:
    <*errors.errorString | 0xc0002abd80>: 
    failed to delete webhook (ID: 49862759): DELETE https://gitlab.com/api/v4/projects/konflux-qe/hacbs-test-project-integration/hooks/49862759: 404 {message: 404 Not found}
    {
        s: "failed to delete webhook (ID: 49862759): DELETE https://gitlab.com/api/v4/projects/konflux-qe/hacbs-test-project-integration/hooks/49862759: 404 {message: 404 Not found}",
    }
occurred

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongweiliu17
Once this PR has been reviewed and has the lgtm label, please ask for approval from kasemalem. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants