Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-1072): refactoring clamav-db to avoid uploading file #328

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

kasemAlem
Copy link
Collaborator

We refactor the image Clamav DB so it supports tools OC and jq
as part of work effort to refactor task Clamav Scan

Issue STONEINTG-1072

@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@64627f9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #328   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        18           
  Lines           ?       502           
  Branches        ?         0           
========================================
  Hits            ?       502           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kasemAlem kasemAlem changed the title feat(STONEINTG-1072): refactoring clamav-db to avoid uploading file for scanning feat(STONEINTG-1072): refactoring clamav-db to avoid uploading file Nov 19, 2024
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-konflux-test branch from 690f6a8 to 9ad061c Compare November 19, 2024 16:05
@jencull
Copy link
Contributor

jencull commented Nov 20, 2024

I see this warning on the changed file @kasemAlem

Screenshot 2024-11-20 at 09 25 34

@kasemAlem kasemAlem force-pushed the STONEINTG-1072-konflux-test branch from 9ad061c to acc1b88 Compare November 21, 2024 11:59
Copy link
Contributor

@Josh-Everett Josh-Everett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM unclear to me the failures however

@kasemAlem kasemAlem force-pushed the STONEINTG-1072-konflux-test branch 15 times, most recently from d405a7f to f1e9c23 Compare November 26, 2024 10:59
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-konflux-test branch 10 times, most recently from 5aa4fdf to 7de53ea Compare November 26, 2024 15:08
Signed-off-by: Kasem Alem <kalem@kalem-thinkpadp16vgen1.raanaii.csb>
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-konflux-test branch from 7de53ea to b98a7ce Compare November 26, 2024 15:20
@kasemAlem
Copy link
Collaborator Author

I see this warning on the changed file @kasemAlem

Screenshot 2024-11-20 at 09 25 34

that was a yamil lint error , was fixed

Copy link
Collaborator

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kasemAlem kasemAlem merged commit c77fa6e into konflux-ci:main Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants