feat(CVP-4333): add more helper functions for FIPS check #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dirgim Could you please help review this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 18
Lines ? 502
Branches ? 0
========================================
Hits ? 502
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This commit adds two functions, first is process_image_digest_mirror_set which takes imageDigestMirrorSet as yaml and returns a map of source and mirrors. The second is replace_image_pullspec which replaces the image registry and repo with that of a mirror. Signed-off-by: Yashvardhan Nanavati <yashn@bu.edu>
yashvardhannanavati
force-pushed
the
check_payload
branch
from
732ee4b to
f6c048a
Compare
dirgim
reviewed
Dec 16, 2024
dirgim
approved these changes
Dec 16, 2024
dirgim
requested review from
14rcole,
Josh-Everett,
hongweiliu17,
kasemAlem and
jencull
arewm
reviewed
Dec 16, 2024
Josh-Everett
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two functions, first is process_image_digest_mirror_set which takes imageDigestMirrorSet as yaml and returns a map of source and mirrors. The second is replace_image_pullspec which replaces the image registry and repo with that of a mirror.