feat: collect log from provisioning rosa HCP #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dannyb48
reviewed
Dec 11, 2024
common/tasks/rosa/hosted-cp/rosa-hcp-deprovision/rosa-hcp-deprovision.yaml
Outdated
Show resolved
Hide resolved
Dannyb48
reviewed
Dec 12, 2024
flacatus
approved these changes
Dec 13, 2024
tasks/rosa/hosted-cp/rosa-hcp-deprovision/0.2/rosa-hcp-deprovision.yaml
Outdated
Show resolved
Hide resolved
tasks/rosa/hosted-cp/rosa-hcp-provision/0.2/rosa-hcp-provision.yaml
Outdated
Show resolved
Hide resolved
Dannyb48
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://issues.redhat.com/browse/KFLUXDP-55
Description
This PR depends on #76 being merged first
It adds
rosa-hcp-provisiontask, that usessecure-push-ocistepaction to push log from cluster provision to OCI storagerosa-hcp-provisiontask, that replaces this task withsecure-push-ocistepaction and addsonError: continuefield to the rest of deprovision steps, to make sure the error in deprovisioning doesn't fail the whole PipelineRun (if it was successful till that point)Verification