-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tekton task to configure sealights for Python. #86
base: main
Are you sure you want to change the base?
Conversation
@flacatus I'm reusing some of your documentation for this. This line here I'm confused about the last "part creates a new trusted artifact with the instrumented code." what is the difference between the create-trusted-artifact task in the go-instrumentation task and building a trusted artifact with the build-sealights-container task? I'm just wondering if maybe I don't need the create-trusted-artifact task here for the python use case UPDATE: |
837e1d8
to
7c46ffe
Compare
@ascerra Golang projects need to inject the sealights package in the source code. go-instrumentation task just instrument the code, and generate the trusted-artifact that will be passed to the build-sealights-container task to build the second container.
No, Definetly for Pyhton and NodeJs you dont need a second build; that mean you dont need the trusted artifacts |
b349d88
to
2c318a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of minor comments/suggestions
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
4a9b995
to
a212be1
Compare
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
a212be1
to
b4854b6
Compare
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
b4854b6
to
7c51ca5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some final questions and comments 🙈
docs/qe-available-tasks/sealights/python-instrumentation/python-instrumentation.md
Outdated
Show resolved
Hide resolved
7c51ca5
to
0478242
Compare
@ascerra can you include the jira link in the commit? git commit -a -m "feat(KFLUXDP-XYZ): >>commit-message<< " |
041bb7e
to
90222d3
Compare
90222d3
to
5d1e94d
Compare
- name: sealights-secret | ||
value: "sealights-credentials" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should be removed now
f05a05b
to
1bc9d3d
Compare
Signed-off-by: Adam Scerra <ascerra@redhat.com>
1bc9d3d
to
0b83e56
Compare
Description
This pull request adds a new Tekton task that makes it easier to configure Python code with Sealights for quality analytics. It retrieves the source code from a trusted artifact, installs Python Sealights agent, configures the app for sealights using vars from your pipeline run, scans all .py files that are not in the --exclude step above and reports scan to sealights, and stores results to be used later on in testing.
A README file is included with clear instructions and an example pipeline to help you get started quickly
Testing
This was tested using this PR where I created a pipeline for the todo-list python example app and ran robot tests in an integration test scenario
ascerra/todo-list-app#15