Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

build(deps): bump the ginkgo group across 2 directories with 1 update #277

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2024

Bumps the ginkgo group with 1 update in the /operator directory: github.com/onsi/ginkgo/v2.
Bumps the ginkgo group with 1 update in the /server directory: github.com/onsi/ginkgo/v2.

Updates github.com/onsi/ginkgo/v2 from 2.19.1 to 2.20.1

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.20.1

2.20.1

Fixes

  • make BeSpecEvent duration matcher more forgiving [d6f9640]

v2.20.0

2.20.0

Features

  • Add buildvcs flag [be5ab95]

Maintenance

  • Add update-deps to makefile [d303d14]
  • bump all dependencies [7a50221]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.20.1

Fixes

  • make BeSpecEvent duration matcher more forgiving [d6f9640]

2.20.0

Features

  • Add buildvcs flag [be5ab95]

Maintenance

  • Add update-deps to makefile [d303d14]
  • bump all dependencies [7a50221]
Commits

Updates github.com/onsi/ginkgo/v2 from 2.19.1 to 2.20.1

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.20.1

2.20.1

Fixes

  • make BeSpecEvent duration matcher more forgiving [d6f9640]

v2.20.0

2.20.0

Features

  • Add buildvcs flag [be5ab95]

Maintenance

  • Add update-deps to makefile [d303d14]
  • bump all dependencies [7a50221]
Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.20.1

Fixes

  • make BeSpecEvent duration matcher more forgiving [d6f9640]

2.20.0

Features

  • Add buildvcs flag [be5ab95]

Maintenance

  • Add update-deps to makefile [d303d14]
  • bump all dependencies [7a50221]
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the ginkgo group with 1 update in the /operator directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo).
Bumps the ginkgo group with 1 update in the /server directory: [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo).


Updates `github.com/onsi/ginkgo/v2` from 2.19.1 to 2.20.1
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.1...v2.20.1)

Updates `github.com/onsi/ginkgo/v2` from 2.19.1 to 2.20.1
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.19.1...v2.20.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ginkgo
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ginkgo
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 22, 2024
@sadlerap
Copy link
Member

Hmmmm, as far as I can tell, dependabot isn't updating nested dependencies in the way I was expecting. e2e has a transitive dependency on ginkgo through its dependency on both operator and server, which in turn require it because of their test suites. This makes an entry for ginkgo in e2e's go.sum.

However, since ginkgo doesn't show up in the go.mod (since e2e doesn't directly depend on ginkgo), dependabot isn't updating it, so when we try to run e2e tests, it fails with a warning to run go mod tidy.

The only way I can see to get dependabot to update the go.sum in this case would be to get e2e to depend on ginkgo or get dependabot to run go mod tidy in this case.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@openshift-ci openshift-ci bot added the lgtm label Aug 22, 2024
Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7d4916a into main Aug 22, 2024
17 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the dependabot/go_modules/operator/ginkgo-38f390862c branch August 22, 2024 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant