This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
ci: move away from differential shellcheck #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential shellcheck was ignoring errors in some cases, which was causing shellcheck warnings not to be picked up. Move away from it and use [shellcheck-sarif][1] as a SARIF provider. [1]: https://docs.rs/crate/shellcheck-sarif/latest Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler <ansadler@redhat.com>
|
An example of shellcheck failures can be found here. |
|
See #63 for an example of this in action. Maybe it's because we weren't using a |
|
Thank you for your feedback. You are right. It is the behavior described in #63 (review) because you have enabled some optional suggestions/checks locally that are not enabled by default. Differential ShellCheck would report the same defects when you would enable them in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential shellcheck was ignoring errors in some cases, which was causing shellcheck warnings not to be picked up. Move away from it and use shellcheck-sarif as a SARIF provider.