Excel Blank Rows Calls mutateBeforeCreate (#66) #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
So this is linked to #66. Basically, I wanted to add in a way to filter out blank rows (excel blank rows not just rows with no data). Although I feel this would be beneficial to have enabled by default, I didn't want to break peoples own implementations of handling this such as handing this in the
handleRecordCreation()
function although I cannot think of a valid use case where people would want to import these blank rows. I'm happy to be led by maintainers as to if we enable this by default or not, I just didn't want to unleash a potentially breaking change.I'm happy to provide a spreadsheet which includes these blank rows if you would like to see this.
Types of changes
What types of changes does your code introduce to Filament Import?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
I will update the documentation now, I also need to run the tests locally (just had a few issues getting them running on my work machine) and I do think it would be beneficial to add in a test which covers these blank rows although I don't think this PR should be dependent on that.