Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devrel 1160/update boilerplate #23

Merged
merged 7 commits into from
Aug 27, 2024
Merged

Conversation

IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral marked this pull request as ready for review August 7, 2024 07:50
@IvanKiral IvanKiral requested review from a team as code owners August 7, 2024 07:50
@IvanKiral IvanKiral force-pushed the DEVREL-1160/update-boilerplate branch 6 times, most recently from a8f4a03 to 218a07b Compare August 12, 2024 06:26
@IvanKiral IvanKiral force-pushed the DEVREL-1160/update-boilerplate branch from 218a07b to 74475e9 Compare August 12, 2024 06:27
package.json Outdated Show resolved Hide resolved
package.json Outdated
"@kontent-ai/eslint-config": "^1.0.0",
"@types/node": "^20.14.10",
"dprint": "^0.47.1",
"lint-staged": "^15.2.7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you deleted the .husky pre-commit hook, this lint-staged and its configuration is no longer needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still the configuration in package.json.

.github/workflows/build.yml Show resolved Hide resolved
src/01_collections.ts Outdated Show resolved Hide resolved
src/02_webSpotlight.ts Outdated Show resolved Hide resolved
src/08_updateType.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@IvanKiral IvanKiral merged commit 1eaa703 into master Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants