🌱 Update config definitions, base configs and initialize call #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dymurray
reviewed
Jan 15, 2025
djzager
previously approved these changes
Jan 15, 2025
There was a problem hiding this comment.
My understanding is that this brings us inline with konveyor/kai#526 . Stealing what Jonah did in #190 😁 . If that is true, this LGTM with the understanding the larger ✨ will come when we move the kai config to it's own file.
Yep, |
Based on changes to the kai runtime configurations in konveyor/kai#526, update the CLI arguments and initialize request object to match. Summary of changes: - Reorder the config field definitions - Use enum values in config definitions where available - Config keys with order 99 probably can be removed as they don't appear to be used - Aligned CLI arguments and initialize request payload types to the updated Kai configuration keys - Dropped config.toml handling since that file is no longer in use Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
sjd78
force-pushed
the
base-config-updates
branch
from
5f9707b to
b43d52c
Compare
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
djzager
previously approved these changes
Jan 15, 2025
Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
djzager
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on changes to the kai runtime configurations in konveyor/kai#526, update the CLI arguments and initialize request object to match.
Summary of changes:
Reorder the config field definitions
Use enum values in config definitions where available
Config keys related to analyzer configuration still remain but cannot be passed along to the analyzer, see kai issue 550
Aligned CLI arguments and initialize request payload types to the updated Kai configuration keys
Dropped config.toml handling since that file is no longer in use
Prerequisite for: #184