Bump pymodbus to version 3.5.4

koutnada · Oct 31, 2023 · 48d1f2c · 48d1f2c
1 parent 461d7d0
commit 48d1f2c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Bump pymodbus to version 3.5.4
+
 ## [3.1.0] - 2023-10-03
 
 ### Added

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -21,7 +21,7 @@ source .venv/bin/activate
 Install the development dependencies:
 
 ```bash
-pip install -e .[lint,format,audit,tests]
+pip install -e ".[lint,format,audit,tests]"
 ```
 
 Now you can start unipi-control with `unipi-control`.

diff --git a/pyproject.toml b/pyproject.toml
@@ -30,7 +30,7 @@ classifiers = [
 requires-python = ">= 3.8"
 dependencies = [
     "aiomqtt==1.2.1",
-    "pymodbus[serial]==3.5.2",
+    "pymodbus[serial]==3.5.4",
     "pyyaml==6.0.1"
 ]
 dynamic = ["version"]

diff --git a/unipi_control/modbus.py b/unipi_control/modbus.py
@@ -43,7 +43,7 @@ async def check_modbus_call(
     try:
         response = await callback(**data)
 
-        if response and response.isError():  # type: ignore[no-untyped-call]
+        if response and response.isError():
             response = None
     except ModbusException as error:
         UNIPI_LOGGER.error("%s %s", LogPrefix.MODBUS, error)