Try to fix zone delegation, by allowing to specifiy record type == NS in rrsets array #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by allowing to specifiy record type == NS in rrsets array
|
Thanks for the PR! To be honest, I do not remember why I included the restriction on NS RRs in the initial RRset; I suspect it's because I assumed that RRset would only contain apex records, and nothing else. Since this module does not include the ability to manage RRs after the initial zone creation, it hadn't crossed my mind to allow NS RRs. This approach is probably fine, but you'll need to correct the spelling of 'delegation' :-) I'll mark the workflows as approved so you can get CI feedback, and then I'll review the PR later this week. |
kpfleming
changed the title
kpfleming
requested changes
Nov 20, 2024
| @@ -34,6 +34,8 @@ for emergencies). | |||
|
|
|||
| - Removed support for Python 3.8. | |||
|
|
|||
| - Fix ability to make zone deligation | |||
There was a problem hiding this comment.
Suggested change
| - Fix ability to make zone deligation | |
| - Fix ability to make zone delegations |
| @@ -46,7 +46,7 @@ | |||
| vars: | |||
| d1_rrset: "{{ lookup('dig_local', 't1.d1.rrset.example.', qtype='A', flat=0, fail_on_error=false, real_empty=false) }}" | |||
|
|
|||
| - name: check for failure when rrset includes NS | |||
| - name: check zone creation with zone deligation | |||
There was a problem hiding this comment.
Suggested change
| - name: check zone creation with zone deligation | |
| - name: check zone creation with zone delegation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm quite a new contributer to ansible collections,
Thank you for creating this collection, very useful!
this seems to work to do subzone deligation for regular dns zones and reverse DNS deligation in my enviroment
I could probably open an issue first, but could you look if this is a workable solution
Regards from Torstein