gpu: Make LightTexture::update_scatter() work in chunks instead of single texels.
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tidy the code and add throughput configuration.
This will be useful for upcoming changes to the light rendering, so we don't have to precisely check the precondition. (Arguably it should return `Option` instead, but this makes sense because, in general, fetching the wrong position *inside* the space is likely going to return `UNINITIALIZED_AND_BLACK` too.)
* Expose the `Texture` and not only the `TextureView`. * Allow adding more `TextureUsages`.
Changed deps to require newer `tokio`. The `tokio::test` macro changed behavior in a way that apparently matters when combining it with `rstest`.
…single texels. This is a workaround for <gfx-rs/wgpu#6827>. However, it should significantly improve throughput too; copying single texels at a time seems to be quite expensive relative to the cost of copying additional texels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for gfx-rs/wgpu#6827. However, it should significantly improve throughput too; copying single texels at a time is quite expensive relative to the cost of copying additional texels. I have not tuned the chunk size.