Various improvements #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcarton
commented
May 21, 2019
mcarton
commented
- Fix review comments from the other PR.
- Update dependencies.
- Document matches in rustdoc. While the guide is really good, having a comprehensive list of all matchers can be helpful.
mcarton
force-pushed
the
various-improvements
branch
from
81f47c8 to
1b88418
Compare
kriomant
requested changes
May 27, 2019
| @@ -511,7 +511,7 @@ fn generate_mock_for_traits( | |||
| }; | |||
| generated_items.push(debug_impl_item); | |||
|
|
|||
| let has_generic_method = Itertools::flatten(traits.iter().map(|&(_, members)| members.iter())) | |||
| let has_generic_method = traits.iter().map(|&(_, members)| members.iter()).flat_map(|x| x) | |||
There was a problem hiding this comment.
It was removed from itertools.
There was a problem hiding this comment.
Yes, because it was added to standard library.
doc/guide.md
Outdated
| @@ -928,7 +928,7 @@ mod tests { | |||
|
|
|||
| ## Error messages | |||
|
|
|||
| The *Mockers* library tries to produce helpful error messages. Note that error messages are better on a nightly compiler, because the `proc_macro_diagnostic` is not yet stable. It highlights key operations so you can easily spot a problem. | |||
| The *Mockers* library tries to produce helpful error messages. It highlights key operations so you can easily spot a problem. Note that error messages are better on a nightly compiler, because the `proc_macro_diagnostic` is not yet stable. | |||
There was a problem hiding this comment.
I dropped this entirely from master because 'errors' here are runtime errors produced by mockers library during test. It has no relation to compile-time errors.
| @@ -3,6 +3,7 @@ use proc_macro2::{Span, TokenStream}; | |||
| use quote::ToTokens; | |||
| use std::collections::{HashMap, HashSet}; | |||
| use std::result::Result; | |||
| use std::sync::atomic::AtomicUsize; | |||
There was a problem hiding this comment.
I already have pending commit replacing ID generators with AtomicUsize, and it's little more comprehensive. So please drop this one.
| @@ -21,6 +26,19 @@ impl<T: Debug, M: MatchArg<T>> MatchArg<Option<T>> for MatchSome<T, M> { | |||
| format!("some({})", self.0.describe()) | |||
| } | |||
| } | |||
|
|
|||
| /// Matches a result for some value matching another matcher. | |||
There was a problem hiding this comment.
"Matches value inside Option with another matcher"?
| $satisfy:ident, $satisfy_clone:ident, | ||
| $expectation:ident, $expectation_times:ident) | ||
| { $(($n:tt, $arg:ident, $Arg:ident)),* } | ||
| $callmatch:ident, $actionclone:ident, |
There was a problem hiding this comment.
No need to rename macro params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.