teams rewrite secret/env functionality #3799
Open
+218
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Holcomb
reviewed
Jan 7, 2025
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
Add configmap mounting for RBAC teams ENG-3182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Implements supporting helm changes for new RBAC teams. This includes token signing secret and teams helm config configmap mountings, env var configuration, and a config block in Values.yaml.
Does this PR rely on any other PRs?
See linked KCM PR.
How does this PR impact users? (This is the kind of thing that goes in release notes!)
See linked KCM PR.
Links to Issues or tickets this PR addresses or fixes
Adds ability to configure new Teams functionality in 2.6.0, including enable/disable, blocking invalid configurations of rbac, and configuring teams via helm values and/or mounting a secret.
What risks are associated with merging this PR? What is required to fully test this PR?
The risks are likely minimal, though testing should be performed for downgrade/upgrade scenarios.
How was this PR tested?
See linked KCM PR.
Have you made an update to documentation? If so, please provide the corresponding PR.
In progress.