Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users that these examples are out-of-date #1178

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

andreyvelich
Copy link
Member

As we discussed on the latest Kubeflow community call, we want to notify users that some examples from this repo are broken.
We got feedback that many new users get started with this repo and can't run the Kubeflow examples.

We don't want to archive this repo for now, since we might want to give this repo second live in the future: #1109

cc @kubeflow/kubeflow-steering-committee @kubeflow/wg-data-leads @kubeflow/wg-pipeline-leads @kubeflow/wg-notebooks-leads @kubeflow/wg-training-leads @kubeflow/wg-automl-leads @kubeflow/wg-manifests-leads

@juliusvonkohout
Copy link
Member

I would link to the community page instead of the Google document but otherwise lgtm

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @andreyvelich

@@ -1,12 +1,23 @@
## Notice
# :warning: **kubeflow/examples Repository is not Maintained**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, I was aware of admonitions but not this option :)

@akgraner
Copy link

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akgraner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a93b143 into kubeflow:master Nov 29, 2024
2 checks passed
@andreyvelich andreyvelich deleted the add-warning branch November 29, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants