feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Live mockup #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paulovmr <832830+paulovmr@users.noreply.github.com>
Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
ederign
approved these changes
Dec 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@paulovmr thank you so much for the quick PR! I'm looking forward to the next ones! :) As I understand this PR will unblock the rest of the team, I'll merge it as is, but could you please do a FUP PR to setup correctly jest (npm run test:jest)? On my commit, I just fixed cypress tests. You can copy what we did on model registry test setup. |
|
Sure, I will send another PR. Thanks, @ederign ! |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136
This PR implements the initial layout, with mocked data, for the Workspaces table:
