Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Add "Connect" column to workspace table and display popup with workspace endpoints. #161

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

Yael-F
Copy link

@Yael-F Yael-F commented Dec 17, 2024

Fixes #150
This PR adds a "Connect" column to the workspace table, positioned before the Actions column.
The new column displays a list of endpoints on hover.

I've added a screenshot of the implementation. Please let me know if any further changes are needed.
image

@google-oss-prow google-oss-prow bot requested a review from ederign December 17, 2024 07:42
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yael <fishel.yael@gmail.com>
@Yael-F Yael-F force-pushed the add_connect_column branch from ba325f5 to eea81bb Compare January 14, 2025 12:04
@Yael-F
Copy link
Author

Yael-F commented Jan 14, 2025

Following a discussion with @jenny-s51, we've decided to move the endpoints into the expanded table row.

The updated screenshot:
image

@thesuperzapper
Copy link
Member

@Yael-F The intention of this button is to connect to the notebook instance (open a new tab), making it the single most important button on the page, it must be in the main row.

The design I was thinking was a button with dropdown to select which port to connect to.

gAt78

NOTE: replace "Primary" with "Jupyter" (or whatever the first port is called), and the other actions being the other ports (or greyed out if there is only one).

NOTE 2: we might also want some kind of "connect" icon on the left side of the button, but I am not sure if that will just clutter.

@ederign
Copy link
Member

ederign commented Jan 15, 2025

@Yael-F I agree with @thesuperzapper! That is the primary action when I open the workspaces listing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

3 participants