feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace Kind column #148 #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
liavweiss
force-pushed
the
kind_logo_modification/#148
branch
from
b29d7cd to
1869d2d
Compare
…Kind column kubeflow#148 Signed-off-by: Liav Weiss (EXT-Nokia) <liav.weiss.ext@nokia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr also contains the implementation of fetch data from workspacekinds API, to be able to take the Icon URL.
In case we have an Icon:
In case we don't have an Icon(broken URL or Icon does not exist):
