Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Commit

Permalink
Delete v1alpha1 API and Controller (#110)
Browse files Browse the repository at this point in the history
* Delete v1alpha1 API and Controller

* Minor fix
  • Loading branch information
johnugeorge authored and k8s-ci-robot committed Nov 21, 2018
1 parent 8d71ff3 commit d33e8ed
Show file tree
Hide file tree
Showing 42 changed files with 5 additions and 4,234 deletions.
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ install:
- gometalinter --install

script:
- go build -o pytorch-operator github.com/kubeflow/pytorch-operator/cmd/pytorch-operator
- go build -o pytorch-operator.v2 github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v2
- go build -o pytorch-operator.v1beta1 github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta1
- gometalinter --config=linter_config.json ./pkg/...
Expand Down
4 changes: 2 additions & 2 deletions build_image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ echo "Create symlink to GOPATH"
mkdir -p ${GOPATH}/src/github.com/kubeflow
ln -s ${CONTEXT_DIR} ${GO_DIR}
cd ${GO_DIR}
echo "Build pytorch operator v1alpha1 binary"
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator
echo "Build pytorch operator v1alpha2 binary"
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v2
echo "Build pytorch operator v1beta1 binary"
go build github.com/kubeflow/pytorch-operator/cmd/pytorch-operator.v1beta1

echo "Building container in gcloud"
gcloud container builds submit . --tag=${IMAGE}:${TAG}
Expand Down
45 changes: 0 additions & 45 deletions cmd/pytorch-operator/app/options/options.go

This file was deleted.

167 changes: 0 additions & 167 deletions cmd/pytorch-operator/app/server.go

This file was deleted.

48 changes: 0 additions & 48 deletions cmd/pytorch-operator/main.go

This file was deleted.

Binary file removed cmd/pytorch-operator/pytorch-operator
Binary file not shown.
9 changes: 1 addition & 8 deletions hack/update-codegen.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,9 @@ CODEGEN_PKG=${CODEGEN_PKG:-$(cd ${SCRIPT_ROOT}; ls -d -1 ./vendor/k8s.io/code-ge
# instead of the $GOPATH directly. For normal projects this can be dropped.
${CODEGEN_PKG}/generate-groups.sh "defaulter,deepcopy,client,informer,lister" \
github.com/kubeflow/pytorch-operator/pkg/client github.com/kubeflow/pytorch-operator/pkg/apis \
pytorch:v1alpha1,v1alpha2,v1beta1 \
pytorch:v1alpha2,v1beta1 \
--go-header-file ${SCRIPT_ROOT}/hack/boilerplate/boilerplate.go.txt

echo "Generating defaulters for pytorch v1alpha1"
${GOPATH}/bin/defaulter-gen --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha1 \
-O zz_generated.defaults \
--go-header-file ./hack/../hack/boilerplate/boilerplate.go.txt \
--output-package github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha1


echo "Generating defaulters for pytorch v1alpha2"
${GOPATH}/bin/defaulter-gen --input-dirs github.com/kubeflow/pytorch-operator/pkg/apis/pytorch/v1alpha2 \
-O zz_generated.defaults \
Expand Down
4 changes: 1 addition & 3 deletions linter_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
"Exclude": [
"redundant return statement",
"comment or be unexported",
"comment on exported",
"pkg/apis/pytorch/v1alpha1/zz_generated.deepcopy.go",
"pkg/apis/pytorch/v1alpha1/zz_generated.defaults.go"
"comment on exported"
],
"Deadline": "300s",
"Skip": ["pkg/client"]
Expand Down
Loading

0 comments on commit d33e8ed

Please sign in to comment.