Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

master: update release-tools #58

Merged
merged 5 commits into from
Dec 10, 2019
Merged

master: update release-tools #58

merged 5 commits into from
Dec 10, 2019

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Nov 21, 2019

Commit summary:
1eaaaa1 Delete kind cluster after tests run.
f41c135 prow.sh: also log output of system containers

NONE

pohly and others added 5 commits November 5, 2019 16:40
@pohly
prow.sh: also log output of system containers
f41c135 
Depending on the error, those logs are needed to debug failures.
@k8s-ci-robot
Merge pull request kubernetes-csi#43 from pohly/system-pod-logging
4fcafec 
prow.sh: also log output of system containers
@mucahitkurt
Delete kind cluster after tests run.
1eaaaa1 
Inside a real Prow job it is better to clean up at runtime instead of leaving that to the Prow job cleanup code because the later sometimes times out.

Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>
@k8s-ci-robot
Merge pull request kubernetes-csi#46 from mucahitkurt/kind-cluster-cl…
a41f386 
…eanup

delete kind cluster after tests run
@pohly
release-tools: update
e945215
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2019
@pohly
Copy link
Contributor Author

pohly commented Dec 10, 2019

/assign @msau42

@msau42
Copy link
Collaborator

msau42 commented Dec 10, 2019

There have been more changes, do you want to include those too?

@pohly
Copy link
Contributor Author

pohly commented Dec 10, 2019

There have been more changes, do you want to include those too?

The script from kubernetes-csi/csi-release-tools#7 doesn't handle updating an existing PR, so no, I would prefer to merge this as-is and later to another round of updates. Also, that way the different repos remain consistent.

@pohly
Copy link
Contributor Author

pohly commented Dec 10, 2019

Also, that way the different repos remain consistent.

They don't need to be, it's just a bit easier to track status when they are...

@msau42
Copy link
Collaborator

msau42 commented Dec 10, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0bb1ff3 into kubernetes-csi:master Dec 10, 2019
dobsonj pushed a commit to dobsonj/node-driver-registrar that referenced this pull request Dec 13, 2023
@openshift-merge-bot
Merge pull request kubernetes-csi#58 from jsafrane/otel-grpc-cve
683ffa1 
OCPBUGS-23811: UPSTREAM: 354: Bump Bump OpenTelemetry to fix CVEs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pohly @k8s-ci-robot @msau42 @mucahitkurt