Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: increase the limit of init container #1296

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Jan 13, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Increase the limit to be equal to the csi-plugin container. Making the limit of init container smaller than main container does not have any benefits.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

We've seem OOMs at init container. Not sure what has changed and triggered this issue yet.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Increase the limit to be equal to the csi-plugin container.
Making the limit of init container smaller than main container does not have any benefits.
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 13, 2025
@huww98
Copy link
Contributor Author

huww98 commented Jan 13, 2025

Tested on alinux3 by run dnf clean all and delete the pod on that node. We need about 350MiB memory to finish a full dnf install session.

Copy link
Contributor

@tydra-wang tydra-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2025
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk, tydra-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit f80a063 into kubernetes-sigs:master Jan 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants