Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] ✨ Add classNamespace to topology #11730

Open
wants to merge 1 commit into
base: release-1.9
Choose a base branch
from
Open

[release-1.9] ✨ Add classNamespace to topology #11730

wants to merge 1 commit into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #11352

/assign Danil-Grigorev

@Danil-Grigorev
Add classNamespace to topology
9599c0f 
- Add documentation on securing cross-namespace access for CC
- Add ByClusterClassRef index
- Support cross-ns CC rebase

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2025
@fabriziopandini
Copy link
Member

Let's defer merging this to when we have are ready to backport also corresponding E2E test

@sbueringer
Copy link
Member

sbueringer commented Jan 22, 2025 •
edited
Loading

@Danil-Grigorev Just a short update. We would suggest this merge order:

  • main: Add classNamespace to topology (done)
  • main: e2e
  • main: clusterctl move
  • then all the cherry-picks

The reason is that clusterctl move at the moment would delete ClusterClasses in the source cluster, which could be a problem if the ClusterClass is used by other Clusters in the source cluster. We'll take a closer look and provide more info / guidance on the clusterctl move PR

@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@Danil-Grigorev Danil-Grigorev

Labels
area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @fabriziopandini @sbueringer @Danil-Grigorev