Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac for metricsCollector #1611

Closed
wants to merge 3 commits into from
Closed

rbac for metricsCollector #1611

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f09c05
fix rbac for metricsCollector
jisnardo Jan 20, 2025
85fcd5a
Merge pull request #1 from jisnardo/jisnardo-patch-1
jisnardo Jan 20, 2025
9e487a0
fix previous pr
jisnardo Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions charts/descheduler/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ rules:
- apiGroups: ["policy"]
resources: ["poddisruptionbudgets"]
verbs: ["get", "watch", "list"]
- apiGroups: ["policy"]
Copy link
Member

@googs1025 googs1025 Jan 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seem to be solved in this pr https://github.com/kubernetes-sigs/descheduler/pull/1599/files and #1596

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great so.

resources: ["poddisruptionbudgets"]
verbs: ["get", "list", "watch"]
{{- if .Values.deschedulerPolicy.metricsCollector.enabled }}
- apiGroups: ["metrics.k8s.io"]
resources: ["pods"]
verbs: ["get", "list", "watch"]
- apiGroups: ["metrics.k8s.io"]
resources: ["nodes"]
verbs: ["get", "list", "watch"]
{{- end }}
{{- if .Values.leaderElection.enabled }}
- apiGroups: ["coordination.k8s.io"]
resources: ["leases"]
Expand Down