✨ handle missing boilerplate file gracefully during scaffolding #4518
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sarthaksarthak9 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @sarthaksarthak9. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
sarthaksarthak9
force-pushed
the
boilerplate
branch
from
6b945f0 to
9da9bac
Compare
sarthaksarthak9
force-pushed
the
boilerplate
branch
from
9da9bac to
093acab
Compare
k8s-ci-robot
added
size/L
| log.Warnf("Unable to find %s: %s.\n"+ "This file is used to generate the license header in the project.\n"+ | ||
| "Note that controller-gen will also use this. Therefore, ensure that you add the license file or configure your project accordingly.", | ||
| s.boilerplatePath, err) | ||
| boilerplate = []byte("") |
There was a problem hiding this comment.
Ig, we have to handle it here also and yesterday you had also mentioned this one.
build/.goreleaser.yml
Outdated
| - -X cmd.goarch={{ .Arch }} | ||
| - -X cmd.gitCommit={{ .Commit }} | ||
| - -X cmd.buildDate={{ .Date }} | ||
| - -X cmd.kubernetesVendorVersion={{ .Env.KUBERNETES_VERSION }} | ||
| targets: | ||
| - linux_amd64 |
There was a problem hiding this comment.
To validate these changes we can:
- I update the script that generate all samples that we have under the testdata in order to remove the hack dir. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh by adding the line
...
header_text "Initializing project ..."
$kb init $init_flags --domain testproject.org --license apache2 --owner "The Kubernetes authors"
rm -rf hack/- Then, I called
make generate
Could you please do that and add the result here in the description of the PR, or let us know the error faced?
There was a problem hiding this comment.
@camilamacedo86 changes are working fine. Share the end lines of the output in the description
sarthaksarthak9
force-pushed
the
boilerplate
branch
from
093acab to
7ddda45
Compare
k8s-ci-robot
added
size/M
sarthaksarthak9
force-pushed
the
boilerplate
branch
from
7ddda45 to
337bc78
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| echo "Warning: Boilerplate file '{{ .BoilerplatePath }}' not found. Proceeding without it."; \ | ||
| echo "You can create it later and regenerate code with the boilerplate using 'make generate'."; \ | ||
| $(CONTROLLER_GEN) object paths="./..."; \ | ||
| fi |
There was a problem hiding this comment.
When we change something that change the scaffolds we need to run make generate so that all samples will be updated. Otherwise, we cannot move forward and get it merged. But you can wait I will review it properly better and provide a good guidance.
Fixes: #4507