fix 2.0: use default transport to mock http requests

pkg/client/client.go

@@ -55,6 +55,14 @@ func AddToScheme() error {
 var DefaultNewClient = NewClient
 
 func NewClient(token, apiEndpoint string) (runtimeclient.Client, error) {
+	return NewClientWitTransport(token, apiEndpoint, &http.Transport{
+		TLSClientConfig: &tls.Config{
+			InsecureSkipVerify: true, // nolint: gosec
+		},
+	})
+}
+
+func NewClientWitTransport(token, apiEndpoint string, transport http.RoundTripper) (runtimeclient.Client, error) {
 	if err := AddToScheme(); err != nil {
 		return nil, err
 	}
@@ -63,11 +71,7 @@ func NewClient(token, apiEndpoint string) (runtimeclient.Client, error) {
 		return nil, err
 	}
 
-	cfg.Transport = &http.Transport{
-		TLSClientConfig: &tls.Config{
-			InsecureSkipVerify: true, // nolint: gosec
-		},
-	}
+	cfg.Transport = transport
 	cfg.BearerToken = string(token)
 	cfg.QPS = 40.0
 	cfg.Burst = 50

pkg/client/client_test.go

@@ -3,6 +3,7 @@ package client_test
 import (
 	"context"
 	"fmt"
+	"net/http"
 	"testing"
 
 	toolchainv1alpha1 "github.com/codeready-toolchain/api/api/v1alpha1"
@@ -26,14 +27,14 @@ import (
 func TestNewClientOK(t *testing.T) {
 	// given
 	t.Cleanup(gock.OffAll)
-	gock.New("http://example.com").
+	gock.New("https://example.com").
 		Get("api").
 		Persist().
 		Reply(200).
 		BodyString("{}")
 
 	// when
-	cl, err := client.NewClient("cool-token", "http://example.com")
+	cl, err := client.NewClientWitTransport("cool-token", "https://example.com", http.DefaultTransport)
 
 	// then
 	require.NoError(t, err)