Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused 'path' after loading config #13

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Mar 19, 2024

not used in the code

Signed-off-by: Xavier Coulon xcoulon@redhat.com

not used in the code

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.33%. Comparing base (650c3ec) to head (3741a10).

Files Patch % Lines
pkg/configuration/configuration.go 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   65.35%   65.33%   -0.02%     
==========================================
  Files          38       38              
  Lines        1980     1979       -1     
==========================================
- Hits         1294     1293       -1     
  Misses        528      528              
  Partials      158      158              
Flag Coverage Δ
unittests 65.33% <45.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xcoulon xcoulon requested review from metlos and fbm3307 as code owners March 20, 2024 08:14
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Just a thought , should we do something of Code Coverage complain ??

@MatousJobanek
Copy link
Contributor

Good question @fbm3307, there are two cases we could theoretically cover, the rest of the complains are related to reading from your home directory (which is very hard to mock and test if you don't want to mess with your home directory), or to some filesystem errors when loading the content of the files, which is very hard to unit test as well.

Anyway, we can take a look at the two cases (when the provided kubeconfig doesn't exist, or when it's a directory) in separate PR - this one is just for dropping the field.

@xcoulon xcoulon merged commit 63b082b into kubesaw:master Mar 21, 2024
4 of 6 checks passed
@xcoulon xcoulon deleted the drop_clusterconfig_path branch March 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants