-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused 'path' after loading config #13
Conversation
not used in the code Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 65.35% 65.33% -0.02%
==========================================
Files 38 38
Lines 1980 1979 -1
==========================================
- Hits 1294 1293 -1
Misses 528 528
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Just a thought , should we do something of Code Coverage complain ??
Good question @fbm3307, there are two cases we could theoretically cover, the rest of the complains are related to reading from your home directory (which is very hard to mock and test if you don't want to mess with your home directory), or to some filesystem errors when loading the content of the files, which is very hard to unit test as well. Anyway, we can take a look at the two cases (when the provided kubeconfig doesn't exist, or when it's a directory) in separate PR - this one is just for dropping the field. |
not used in the code
Signed-off-by: Xavier Coulon xcoulon@redhat.com