-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: init new ksctl adm install-operators command #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing both operators at the same time can result in a bad UX. I would rather install the operators separately.
Let's discuss it in the slack https://redhat-internal.slack.com/archives/C06MJ2DVBU4/p1721721123457769
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Just a minor thing It would be good if we can increase the code coverage by adding more test cases if possible
thanks ! I'll see what I can do. Most of these are error cases , I think a few of them should not be difficult to trigger. |
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for addressing my comments 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 67.33% 67.83% +0.49%
==========================================
Files 43 44 +1
Lines 2336 2515 +179
==========================================
+ Hits 1573 1706 +133
- Misses 581 617 +36
- Partials 182 192 +10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Jira: https://issues.redhat.com/browse/KUBESAW-120, https://issues.redhat.com/browse/KUBESAW-165
Create new
ksctl adm install-operator <member|host> --kubeconfig </path/to/kubeconfig> --namespace <namespace>
command.