Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: init new ksctl adm install-operators command #48

Merged
merged 51 commits into from
Aug 20, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Jul 11, 2024

Jira: https://issues.redhat.com/browse/KUBESAW-120, https://issues.redhat.com/browse/KUBESAW-165

Create new ksctl adm install-operator <member|host> --kubeconfig </path/to/kubeconfig> --namespace <namespace> command.

  • command skeleton
  • install host operator
  • install member operators
  • unit tests
  • more logs

@mfrancisc mfrancisc marked this pull request as ready for review July 23, 2024 07:42
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installing both operators at the same time can result in a bad UX. I would rather install the operators separately.
Let's discuss it in the slack https://redhat-internal.slack.com/archives/C06MJ2DVBU4/p1721721123457769

@mfrancisc mfrancisc requested a review from MatousJobanek July 25, 2024 13:17
Copy link
Contributor

@fbm3307 fbm3307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just a minor thing It would be good if we can increase the code coverage by adding more test cases if possible

@mfrancisc
Copy link
Contributor Author

looks good. Just a minor thing It would be good if we can increase the code coverage by adding more test cases if possible

thanks ! I'll see what I can do. Most of these are error cases , I think a few of them should not be difficult to trigger.

pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
mfrancisc and others added 13 commits August 9, 2024 14:45
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
pkg/cmd/adm/install_operator.go Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Show resolved Hide resolved
pkg/cmd/adm/install_operator_test.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator_test.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator.go Outdated Show resolved Hide resolved
pkg/cmd/adm/install_operator_test.go Outdated Show resolved Hide resolved
mfrancisc and others added 6 commits August 14, 2024 07:39
Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing my comments 👍

@mfrancisc mfrancisc merged commit f7f37c5 into kubesaw:master Aug 20, 2024
7 checks passed
@mfrancisc mfrancisc deleted the installcmd branch August 20, 2024 12:37
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 74.30168% with 46 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (2cf7e16) to head (fe53e0a).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/cmd/adm/install_operator.go 77.01% 29 Missing and 8 partials ⚠️
pkg/client/client.go 69.23% 2 Missing and 2 partials ⚠️
pkg/context/command_context.go 0.00% 4 Missing ⚠️
pkg/cmd/adm/adm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   67.33%   67.83%   +0.49%     
==========================================
  Files          43       44       +1     
  Lines        2336     2515     +179     
==========================================
+ Hits         1573     1706     +133     
- Misses        581      617      +36     
- Partials      182      192      +10     
Files Coverage Δ
pkg/cmd/adm/adm.go 0.00% <0.00%> (ø)
pkg/client/client.go 52.32% <69.23%> (+0.98%) ⬆️
pkg/context/command_context.go 55.55% <0.00%> (-44.45%) ⬇️
pkg/cmd/adm/install_operator.go 77.01% <77.01%> (ø)

Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants