feat: move add-cluster.sh script logic into register-member command #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancisc
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
sbryzak,
drpaneas,
metlos and
fbm3307
as code owners
# Conflicts: # pkg/cmd/adm/register_member.go
metlos
reviewed
Aug 6, 2024
added 2 commits
August 16, 2024 11:36
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
metlos
approved these changes
Aug 22, 2024
MatousJobanek
approved these changes
Aug 27, 2024
Co-authored-by: Matous Jobanek <mjobanek@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 68.63% 69.45% +0.81%
==========================================
Files 43 43
Lines 2468 2544 +76
==========================================
+ Hits 1694 1767 +73
- Misses 584 587 +3
Partials 190 190
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/KUBESAW-27
Update the
ksctl register-membercommand so that it doesn't rely anymore on the execution of theadd-cluster.shscript. The logic from the bash script is now implemented in Golang. The original idea was to convert only since the creation of the Secret containing the kubeconfig, but I found it easier to convert the entire logic and remove the execution of the bash script. This simplifies the code and the tests.The creation of the toolchaincluster is just temporary until we implement https://issues.redhat.com/browse/KUBESAW-44, which will move the creation of TC in the toolchaincluster_resource controller and will remove it from here.