Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase wait for install timeout #65

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

mfrancisc
Copy link
Contributor

@mfrancisc mfrancisc commented Aug 21, 2024

Move timeout to cli args and increase the default timeout.
On crc it fails sometimes since the catalogsource becomes ready later.

Installing latest version of the host-operator
/Users/fmuntean/go/src/github.com/codeready-toolchain/toolchain-e2e/build/_output/bin/ksctl adm install-operator host --kubeconfig "/Users/fmuntean/.kube/config" --namespace toolchain-host-21201257 -y

Are you sure that you want to install host in namespace 'toolchain-host-21201257'
===============================
[y/n] -> response: 'y'
Namespace toolchain-host-21201257 created.
Creating CatalogSource host-operator in namespace toolchain-host-21201257.
CatalogSource host-operator created.
waiting for CatalogSource toolchain-host-21201257/host-operator to become ready
...
waiting for CatalogSource toolchain-host-21201257/host-operator to become ready
Error: failed waiting for catalog source to be ready.

Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pkg/cmd/adm/install_operator.go Show resolved Hide resolved
@mfrancisc mfrancisc merged commit 0ffc21a into kubesaw:master Aug 21, 2024
6 of 7 checks passed
@mfrancisc mfrancisc deleted the increasetimeout branch August 21, 2024 20:34
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.41%. Comparing base (cdad74f) to head (90d87b3).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/cmd/adm/install_operator.go 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   68.44%   68.41%   -0.03%     
==========================================
  Files          43       43              
  Lines        2475     2476       +1     
==========================================
  Hits         1694     1694              
- Misses        591      592       +1     
  Partials      190      190              
Files Coverage Δ
pkg/cmd/adm/install_operator.go 76.54% <60.00%> (-0.48%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants