Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update linter config and fix lint issues #71

Merged
merged 2 commits into from
Sep 4, 2024

also, update golangci-lint version in GH Action

e430f08
Select commit
Loading
Failed to load commit list.
Merged

update linter config and fix lint issues #71

also, update golangci-lint version in GH Action
e430f08
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2024 in 1s

69.61% (+0.00%) compared to fd7b434

View this Pull Request on Codecov

69.61% (+0.00%) compared to fd7b434

Details

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.61%. Comparing base (fd7b434) to head (e430f08).

Files with missing lines Patch % Lines
pkg/cmd/generate/cli_configs.go 50.00% 1 Missing ⚠️
pkg/ioutils/terminal.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   69.61%   69.61%           
=======================================
  Files          43       43           
  Lines        2564     2564           
=======================================
  Hits         1785     1785           
  Misses        588      588           
  Partials      191      191           
Files with missing lines Coverage Δ
pkg/cmd/generate/cli_configs.go 74.65% <50.00%> (ø)
pkg/ioutils/terminal.go 61.11% <0.00%> (ø)