Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-172: Restart host-operator at the end of the register-member command #90

Merged
merged 13 commits into from
Dec 23, 2024

improving the readability and cosmetic changes

53aaed1
Select commit
Loading
Failed to load commit list.
Merged

KUBESAW-172: Restart host-operator at the end of the register-member command #90

improving the readability and cosmetic changes
53aaed1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

67.83% (-0.20%) compared to f99bb4a

View this Pull Request on Codecov

67.83% (-0.20%) compared to f99bb4a

Details

Codecov Report

Attention: Patch coverage is 44.44444% with 25 lines in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (f99bb4a) to head (53aaed1).

Files with missing lines Patch % Lines
pkg/cmd/adm/register_member.go 31.57% 13 Missing ⚠️
pkg/cmd/adm/restart.go 52.00% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   68.02%   67.83%   -0.20%     
==========================================
  Files          44       44              
  Lines        3240     3264      +24     
==========================================
+ Hits         2204     2214      +10     
- Misses        841      853      +12     
- Partials      195      197       +2     
Files with missing lines Coverage Δ
pkg/cmd/adm/unregister_member.go 54.54% <100.00%> (ø)
pkg/cmd/adm/restart.go 58.28% <52.00%> (+1.13%) ⬆️
pkg/cmd/adm/register_member.go 71.65% <31.57%> (-2.12%) ⬇️