Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unregister-member deletes secret & has needed permissions #99

Merged
merged 3 commits into from
Jan 10, 2025

meesage when secret not present

325af8b
Select commit
Loading
Failed to load commit list.
Merged

fix: unregister-member deletes secret & has needed permissions #99

meesage when secret not present
325af8b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

67.80% (-0.03%) compared to ec701fa

View this Pull Request on Codecov

67.80% (-0.03%) compared to ec701fa

Details

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (ec701fa) to head (325af8b).

Files with missing lines Patch % Lines
pkg/cmd/adm/unregister_member.go 64.70% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   67.83%   67.80%   -0.03%     
==========================================
  Files          44       44              
  Lines        3264     3280      +16     
==========================================
+ Hits         2214     2224      +10     
- Misses        853      857       +4     
- Partials      197      199       +2     
Files with missing lines Coverage Δ
pkg/cmd/adm/unregister_member.go 56.66% <64.70%> (+2.12%) ⬆️