fix(rsp): current pod resource usage should be included in resource calculation #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
changed the title
SOF3
force-pushed
the
fix/subtract-previous-usage
branch
from
53e0b14 to
dd872dd
Compare
SOF3
force-pushed
the
fix/subtract-previous-usage
branch
from
281f67c to
5aad843
Compare
gary-lgy
reviewed
May 2, 2023
gary-lgy
reviewed
May 2, 2023
| usageTmp := currentUsage[cluster.Name] | ||
| usage := *usageTmp.Clone() | ||
|
|
||
| usage.Add(available) |
There was a problem hiding this comment.
Can we add a comment here to explain why this is necessary
SOF3
force-pushed
the
fix/subtract-previous-usage
branch
from
bbd093d to
096c337
Compare
gary-lgy
reviewed
May 11, 2023
|
I replaced the apiserver list request with a label-indexed pod cache in the pull request here: SOF3#1 I wrote a few simple unit tests but I am not very confident if the tests are comprehensive enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.