-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: integrate the codecov #251
Conversation
Does the coverage data here include packages without any test files? See golang/go#24570 I did a workaround in kelemetry because of this issue kubewharf/kelemetry@2647219 |
I noticed this problem and it seems to be solved by adding the When I experimented in my repository, it seemed that the coverage would include all packages in the According to experimental results, the old test report will not cover packages that do not contain single tests(coverage of Actually, I'm not sure why the above solution works, but it seems to solve the problem😂. Can you please help confirm if this solution meets expectations? @SOF3 |
@qclc It seems the packages were included simply because your PR had diff in those packages. Maybe try with another commit that does not involve those packages? Would the total coverage decrease again? |
@SOF3 I experimented again and only modified the package containing the unit test. The coverage remained unchanged, which was also ~24% : https://app.codecov.io/gh/qclc/kubeadmiral/pull/4 . I also ran |
8b0cd36
to
b9cf506
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Sorry to miss this comment on issue (golang/go#24570 (comment)) : using The end result still requires some additional work to ensure coverage is reported for every package, as @SOF3 did in repository kelemetry. Please take a review. |
Add code coverage detection and ensure that 60%or higher of new code is covered with unit tests.
Currently we only focus on the coverage in the
./pkg
directory, and will ignore the following packages or files in this directory: