-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(install): add separate install guide for each env #2054
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
✅ Deploy Preview for kuma ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this page looks poor, can we do something to improve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it?
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
@@ -19,8 +19,27 @@ items: | |||
url: "/introduction/how-kuma-works/#kuma-vs-xyz" | |||
- text: Architecture | |||
url: /introduction/architecture/ | |||
- text: Install Kuma | |||
url: /introduction/install-kuma/ | |||
- title: Install Kuma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this could be a separate top level entry in sidebar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should replace: https://kuma.io/docs/2.9.x/production/cp-deployment/multi-zone/ do we need to move anything from old guide somewhere before we remove it?
# Conflicts: # .github/styles/config/vocabularies/Base/reject.txt
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>
``` | ||
3. Find the external IP and port of the `{{site.mesh_product_name}}-global-zone-sync` service in the {{site.mesh_namespace}} namespace: | ||
```shell | ||
kubectl get service {{site.mesh_product_name}}-global-zone-sync -n {{site.mesh_namespace}} -ojson -o jsonpath='{.status.loadBalancer.ingress[0].ip}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add this to an env var and use it just after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement.
One thing comes to me is do we need to differentiate single-zone and multi-zone.
Should we have instead a guide to install a zone and a guide to install a global.
In the zone we'd have a tab to select whether this zone is federated (connects to a global CP) or not (old standalone).
Feels to me that this would create less pages but also less options and in the end be clearer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it?
We should have all install guide centralized and easy to find, as now they are buried somewhere in production docs
Fix: #1334 and #1249