Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ドキュメントの更新 #811

Merged
merged 19 commits into from
Dec 9, 2020
Merged

ドキュメントの更新 #811

merged 19 commits into from
Dec 9, 2020

Conversation

hrtwt
Copy link
Contributor

@hrtwt hrtwt commented Dec 5, 2020

resolve #636 #689 #759 #766

行ったこと

CONTRIBUTING

  • submodule の pull 方法を追加
  • JDK8+ → JDK11+ に変更
  • リンク切れを修正
  • fat JAR 生成方法を追加

README 日英両方

  • README のGradle の項 を H2 → H3 に変更
  • 不足していたオプションの説明を追加

kgenprog-config-template.toml

不足していたオプションの説明を追加

Configuration.java

並び替え
オプションの順をドキュメントと合わせるため

行わなかったこと

--no-output のドキュメントへの追記
#807 で削除予定のため

@clione-bot
Copy link

clione-bot bot commented Dec 5, 2020

No problem. Good job!

Copy link
Contributor

@tt-kuma tt-kuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい所が多いですがコメント付けました.
更新されていない箇所があったので以下も追加でお願いします.

  • CascadeCrossoverの追加 (READMEのオプション,OVERVIEW)
  • HeuristicMutationの追加 (OVERVIEW)

README.md Show resolved Hide resolved
doc/ja/README.md Show resolved Hide resolved
doc/ja/README.md Outdated Show resolved Hide resolved
doc/kgenprog-config-template.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
doc/kgenprog-config-template.toml Outdated Show resolved Hide resolved
doc/kgenprog-config-template.toml Outdated Show resolved Hide resolved
@hrtwt
Copy link
Contributor Author

hrtwt commented Dec 8, 2020

レビューありがとうございます.
修正しましたので,ご確認をお願いします.

Copy link
Contributor

@tt-kuma tt-kuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうなのでマージします.
お疲れさまでした.

Copy link
Contributor

@tt-kuma tt-kuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージしようとしたらコンフリクトしてたので対応お願いします.
masterに合わせればよいと思います.

@hrtwt
Copy link
Contributor Author

hrtwt commented Dec 8, 2020

コンフリクト解消しました.

@tt-kuma
Copy link
Contributor

tt-kuma commented Dec 9, 2020

今度こそマージします.
お疲れさまでした.

@tt-kuma tt-kuma merged commit a779172 into master Dec 9, 2020
@hrtwt hrtwt deleted the update-docs branch December 9, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants