Support alter for rel groups #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
commented
Jan 21, 2025
src/catalog/catalog_set.cpp
Outdated
| void CatalogSet::alterEntry(Transaction* transaction, const binder::BoundAlterInfo& alterInfo) { | ||
| void CatalogSet::alterRelGroupEntry(Transaction* transaction, | ||
| const binder::BoundAlterInfo& alterInfo) { | ||
| CatalogEntry* entry = nullptr; |
There was a problem hiding this comment.
A good amount of this is duplicated with alterTableEntry it might be good to refactor out some of the duplicate logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4764 +/- ##
==========================================
- Coverage 86.32% 86.29% -0.03%
==========================================
Files 1397 1397
Lines 59840 60003 +163
Branches 7377 7390 +13
==========================================
+ Hits 51656 51779 +123
- Misses 8017 8057 +40
Partials 167 167 ☔ View full report in Codecov by Sentry. |
royi-luo
commented
Jan 22, 2025
Comment on lines
+37
to
+43
| KU_ASSERT(tableAlterInfo.tableName.starts_with(relGroupEntry->getName())); | ||
| // table name is in format {rel_group_name}{suffix} | ||
| // rename to {new_rel_group_name}{suffix} | ||
| auto& renameInfo = tableAlterInfo.extraInfo->cast<BoundExtraRenameTableInfo>(); | ||
| auto tableNameSuffix = tableEntry->getName().substr(relGroupEntry->getName().size()); | ||
| renameInfo.newName.append(tableNameSuffix); |
There was a problem hiding this comment.
do we want renaming rel group to also rename the child tables?
There was a problem hiding this comment.
I'm not sure. I guess it's better to also rename children tables so that the naming convention if preserved after ALTER
There was a problem hiding this comment.
I think we should also rename the child tables to maintain consistency. Later, we might consider removing table names from the Catalog entirely.
andyfengHKU
reviewed
Jan 22, 2025
There was a problem hiding this comment.
Overall LGTM.
@ray6080 should check if the new record can be omitted and if we need to store alterInfo in TableCatalogEntry.
Comment on lines
+37
to
+43
| KU_ASSERT(tableAlterInfo.tableName.starts_with(relGroupEntry->getName())); | ||
| // table name is in format {rel_group_name}{suffix} | ||
| // rename to {new_rel_group_name}{suffix} | ||
| auto& renameInfo = tableAlterInfo.extraInfo->cast<BoundExtraRenameTableInfo>(); | ||
| auto tableNameSuffix = tableEntry->getName().substr(relGroupEntry->getName().size()); | ||
| renameInfo.newName.append(tableNameSuffix); |
There was a problem hiding this comment.
I'm not sure. I guess it's better to also rename children tables so that the naming convention if preserved after ALTER
| const auto* tableEntry = catalog->getTableCatalogEntry(transaction, tableID); | ||
| BoundAlterInfo tableAlterInfo = info.copy(); | ||
| tableAlterInfo.tableName = tableEntry->getName(); | ||
| if (tableAlterInfo.alterType == common::AlterType::RENAME_TABLE) { |
There was a problem hiding this comment.
I guess it's better to do this in bind_ddl.cpp?
ray6080
force-pushed
the
royi/rel-group-alter
branch
from
70f3248 to
351e37b
Compare
ray6080
force-pushed
the
royi/rel-group-alter
branch
from
6d09d27 to
9a5eaf1
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
force-pushed
the
royi/rel-group-alter
branch
from
67cf682 to
0e8cb68
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
approved these changes
Jan 23, 2025
| @@ -278,7 +278,9 @@ class Binder { | |||
| const BoundProjectionBody& boundProjectionBody); | |||
| static bool isOrderByKeyTypeSupported(const common::LogicalType& dataType); | |||
|
|
|||
| void validateTableExist(const std::string& tableName) const; | |||
| void validateTableExists(const std::string& name) const; | |||
| void validateNoIndexOnProperty(const std::string& tableName, | |||
There was a problem hiding this comment.
These two can be hide in bind_ddl.cpp right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ALTERon rel groups, propagating the changes to the child tablesTODOs:
rollback.test)Fixed #4762 as well.
Contributor agreement