Update HealthKitReader.swift #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add anchor to storage for HKQueryAnchor
|
Hi @sangle1996 thank you for your MR and please sorry I didn't look at it earlier... TBH I wouldn't involve anything like UserDefault in this library, as it should be agnostic and it is integrator's responsibility to store anchors if they want and I would keep the HealthKitReader class stateless. If you have an idea to make wrappers for the anchors following up the code style in the project you are more than welcome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add anchor to storage for HKQueryAnchor
Status
READY/IN DEVELOPMENT/HOLD
Migrations
YES | NO
Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs against other branches:
branch PR
other_pr_production link
other_pr_master link
Todos
Tests
Documentation
Deploy Notes
Notes regarding deployment the contained body of work. These should note any db migrations, etc.
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.
git pull --prune
git checkout <feature_branch>
Impacted Areas in Application
Small description about what will be changed in the app if this PR will be merged
List general components of the application that this PR will affect:
The direct changes inside the app made by this PR