New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add HandleEmtpyInListsPlugin. #925

Merged

igalklebanov merged 14 commits into kysely-org:v0.28 from austinwoon:feat/safe-empty-where-in-plugin

Dec 15, 2024

austinwoon commented Mar 29, 2024 •

edited by igalklebanov

Loading

Hey 👋

closes #709.

This PR was created initially by @austinwoon, and revisited/expanded by @igalklebanov.

It adds HandleEmptyInListsPlugin to allow you to handle in () and not in () with a chosen strategy.

It ships with 2 strategies out-the-box:

replaceWithNoncontingentExpression - Replaces in () with 1 = 0 and not in () with 1 = 1 - the strategy used by Knex.js, PrismaORM, Laravel and SQLAlchemy.
pushValueIntoList(uniqueValue: string) - Replaces in () with in (null) - the strategy used by TypeORM and Sequelize, and not in () with cast({{leftOperand}} as char) in ('{{uniqueValue}}').

It also supports custom strategies, e.g.:

throw an error so a request is not sent to the database.
print a warning and apply one of the built-in strategies.
mix the built-in strategies, e.g. in (null) and 1 = 1.

vercel bot commented Mar 29, 2024 •

edited

Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 15, 2024 5:42pm

vercel bot deployed to Preview

March 29, 2024 17:09

View deployment

igalklebanov added enhancement built-in plugin labels

vercel bot deployed to Preview

March 30, 2024 15:29

View deployment

vercel bot deployed to Preview

March 30, 2024 15:43

View deployment

vercel bot deployed to Preview

April 21, 2024 10:29

View deployment

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

src/plugin/safe-empty-array-where-in/safe-empty-array-where-in.transformer.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

igalklebanov reviewed

View reviewed changes

test/node/src/safe-empty-where-in.test.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview

April 25, 2024 15:23

View deployment

vercel bot deployed to Preview

April 25, 2024 15:30

View deployment

austinwoon requested a review from igalklebanov

April 25, 2024 15:31

vercel bot deployed to Preview

April 25, 2024 15:41

View deployment

igalklebanov changed the base branch from master to v0.28

December 8, 2024 17:31

igalklebanov force-pushed the v0.28 branch from 09d7ab0 to c937f1a Compare

December 8, 2024 17:43

Austin Woon added 13 commits

December 14, 2024 14:00


          feat: empty where in plugin


          test: add new tests

25872f1


          chore: remove unneccesary typeguards

4b2caa3


          fix: change to binary operator node

56b41d2


          test: update tests to do both in and not in

84631f1


          test: for having

19e1128


          chore: rm test

36fa496


          test: nullable tests

26823f0


          chore: nit

86fde47


          chore: condense suite

76cf85d


          chore: db config override

f7d46d6


          chore: extra console log

643b3f2


          chore: empty arr plugin docs

b169551

igalklebanov force-pushed the feat/safe-empty-where-in-plugin branch from 62618ed to b169551 Compare

December 14, 2024 12:00

vercel bot deployed to Preview

December 14, 2024 12:00

View deployment


          HandleEmptyInListsPlugin initial commit.

30d5a6a

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

vercel bot deployed to Preview

December 15, 2024 17:42

View deployment

pkg-pr-new bot commented Dec 15, 2024

Open in Stackblitz • kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@925

commit: 30d5a6a

igalklebanov changed the title ~~feat: add safe empty where in plugin~~ feat: add HandleEmtpyInListsPlugin.

igalklebanov merged commit 6be09d8 into kysely-org:v0.28

24 checks passed

Member

igalklebanov commented Dec 15, 2024 •

edited

Loading

Went over it and expanded the use case. You can choose which strategy to apply and there are 2 built-in strategies to choose from and support for custom ones.

This'll probably land in v0.28! 🥳

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

3d4636b

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

igalklebanov self-assigned this

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

1a41856

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

5457cb5

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

5e557bf

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

0e3d29d

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

igalklebanov added a commit that referenced this pull request


          feat: add HandleEmtpyInListsPlugin. (#925)

8524c3c

* feat: empty where in plugin

* test: add new tests

* chore: remove unneccesary typeguards

* fix: change to binary operator node

* test: update tests to do both in and not in

* test: for having

* chore: rm test

* test: nullable tests

* chore: nit

* chore: condense suite

* chore: db config override

* chore: extra console log

* chore: empty arr plugin docs

* HandleEmptyInListsPlugin initial commit.

Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

---------

Co-authored-by: Austin Woon <austin@open.gov.sg>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
remove only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built-in plugin enhancement