Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcs QoL update. Select streams manually, removed compulsive select all before start #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lokinou
Copy link

@lokinou lokinou commented Jul 21, 2023

Removed the compulsive select all before start when using rcs commands.
Remove control of labrecorder can now provide fine selection of streams

Added

  • select <search_str>
  • regexselect <regex_str>

example
"select liveamp"
"regexselect liveamp[0-9]+"

…s streams. regexselect <regex> selects streams.
@cboulay
Copy link
Contributor

cboulay commented Jul 22, 2023

Hi and thanks for the PR!

What should happen when a RCS user attempts to start recording with no streams selected?

  1. Returns an error message
  2. Selects all streams (preserves prior behavior) and records

@lokinou
Copy link
Author

lokinou commented Jul 22, 2023

Thanks for the quick reply @cboulay ,

I would go for an error message.

I speak for my specific use of the software that may run on a university network where other amplifiers and HMD devices can pop on anytime and disrupt measurements.

I would be ok with a select all being triggered after the gui/cli opens, to preserve a little bit of consistency with prior work.
The way it was designed: start = select all + start it left no choice for a rcs client to actually pick the desired streams, not even after transmitting a config file or using select none. Also I added select <str_search> and regexselect <str_pattern> for covering the missing functionnality.

@cboulay
Copy link
Contributor

cboulay commented Jul 23, 2023

@lokinou , there really isn't a perfect solution because preserving existing behaviour is also contrary to how the (much more commonly used) GUI works. if we're going to change default behaviour then we might as well align with the GUI. So, I'd be OK with leaving the streams unselected at startup (unless specified by config file) then raising an error if trying to record without any streams selected. (Selected and not-yet-available should be allowed).

Would you be willing to modify your PR in that way?

@cboulay
Copy link
Contributor

cboulay commented Jul 23, 2023

Linking to #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants