Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make subscription_id required for Azure Activity Log and Config #1681

Merged
merged 15 commits into from
Dec 6, 2024

Conversation

PengyuanZhao
Copy link
Contributor

Summary

  • subscription_id is required for Azure Activity Log and Config

How did you test this change?

Run lacework generate cloud-account azure --noninteractive --activity_log, get and error
Screenshot 2024-12-03 at 4 16 59 PM

Run lacework generate cloud-account azure --noninteractive --activity_log --subscription_id 123123, terraform gets generated successfully
Screenshot 2024-12-03 at 4 36 02 PM

@PengyuanZhao PengyuanZhao requested a review from a team as a code owner December 4, 2024 00:36
@PengyuanZhao PengyuanZhao requested review from thekeys93, aneesh-mysore, aclacework, leijin-lw and Manan-Bhatia-0 and removed request for a team December 4, 2024 00:36
Copy link

github-actions bot commented Dec 4, 2024

All issues previously detected by Lacework Code Security have been resolved!

Copy link
Contributor

@Manan-Bhatia-0 Manan-Bhatia-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please address the comment about the condition checking for SubscriptionID

@PengyuanZhao PengyuanZhao enabled auto-merge (squash) December 5, 2024 17:58
@PengyuanZhao PengyuanZhao merged commit 0098e71 into main Dec 6, 2024
11 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/require-subscription-id branch December 6, 2024 18:09
@lacework-releng lacework-releng mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants