Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input check on BabySnark #960

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jotabulacios
Copy link
Contributor

@jotabulacios jotabulacios commented Jan 13, 2025

Add input check on BabySnark

Description

This PR adds an additional check to the input values to ensure that the first element of the input 1. This constraint is necessary to maintain the consistency of quadratic constraints

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization

Checklist

  • Linked to Github Issue
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.32%. Comparing base (6fb54a2) to head (f16f6e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #960   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files         155      155           
  Lines       33537    33537           
=======================================
  Hits        23920    23920           
  Misses       9617     9617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotabulacios jotabulacios marked this pull request as ready for review January 13, 2025 20:18
@jotabulacios jotabulacios requested a review from a team as a code owner January 13, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants