-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trim function #64
Open
Whizzkid-FG
wants to merge
64
commits into
ferguson
Choose a base branch
from
master
base: ferguson
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
trim function #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
修改Script.php文件中的connection为本地root连接
添加jquery-ui.css和jquery-ui.js的1.12.1版本
邀请前检查该student_id是否已存在
修改了错误的title,添加插入course_groups_table的代码
修改已添加成员后的提示
…ission error Bug No.177.
…urse after entering the course code.
Removed a duplicated line that was done by mistake on line 531 $('#submit-form').submit()
For the LRR website, we don't need to display both the sign-in and sign-up forms on one page. The best thing that we can do to have a clean and neat LRR website UI/UX we should only display the logo and sign in form. Then we are also going to put a signup link on the sign-in page that will lead to the signup form and on the signup form the top left corner lrr logo will lead us back to the sign-in form. On the sign-up form I have removed the portal for inputting the passport and added an if statement for inputting student number on the same form.
Updated the Logo from "LRRS" to "LRR". Removed the signup form from the index.php file (Index.php file had two forms now with only one form for signing in and a link that leads to the signup form). On the signup form, we have removed the portal for putting the passport because I have realized that our colleagues from this repository "Ashik-Nafis_Bug 53" only removed the passport portal from the form. We also added a background and some CSS properties for the hovers effects on the new form.
This is the new background image for the lrr sign in form.
We added first increased the padding for the recover button and also added some CSS properties for the hover effect.
Line 44, 53 - 60 we removed the passport portal not just from the form as our colleagues did but completely. Apart from the change above we also added a portal for inputting the student number on line 64.
Student can create the accounts on their own without the need for the Teacher to create the accounts for the students. Also removed the inputs for the passport.
When a student enters a student number without the email he/she can not recover their password unless the enter both details and if not all details are correct the following error messages will be displayed; "Invalid student number" or "Invalid email address". These error messages will be displayed on the same page without navigating to the next page as before. Line 222 - 224 and 230 - 232. On Line 246 - 247 after resetting your password the recover buttons navigates direct to the signup.php where you can create a new account.
Removed the passport number entries from the code.
Removed the letter S from the "LRRS" to "LRR".
Enock Khondowe 202025800044 & Samantha Rusike 202025800046: Mark Subm…
Mabasa Nyasha Mutyambizi 202025800045-Fixed Bug 51:
I have removed the background and the "S" in the name on the footer too make it consistent with the rest as we renamed it to LRR only.
index.php: make the code look cleaner.
…e-Search-For-Courses Courses.php: trim course code before search for it.
…howMissedCourses
Hui incorporate changes made by Enock
signup.php: use proper lowercases.
recover_password.php: require that the two fields must not be empty.
…he system shows the information of the person that submit the assignement.
README.md: highlight important contributors.
…engXiaoyu Hui incorporate changes made by zheng xiaoyu
Hui updated README.md in master
Corrected the wrong spelling which was spelt as "happend" instead of "Happened".
This fix was made by Enock. See the following link for more detail. https://sourcegraph.com/github.com/lanlab-org/LRR/-/commit/d8ea11fe17ef7f497e50d7566feb40afb1c1bbc7 -Hui
…ock2 Script.php: fix typo happend
We replace "$names $submitted_std <i>(GROUP)</i> $groupname " with "$names ($submitted_std) for group $groupname"? We made variable names more descriptive by replacing submitted_std with submitter_student_number and also names with student_name
…ab-org/LRR into Hui-IncorporateChangesMadeByEnock2
…achment from a student's submission (file name containing commas)
…hat we can go bact to the list of assignments.
Enock Omar Jeannick bug 42: please add a link under assignments so t…
…to BugFix-201-Mabasa-Samantha-Nafis
…x-201-Mabasa-Samantha-Nafis
Mabasa, Samantha, and Nafis - Fixed Bug 201 Unable to download an att…
…mprove-README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.