Omit redundant parent ID validation #732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #725, we can use
meta.parent
to generate routes with nested model binding. For example, this draft:... generates the following routes:
Laravel automatically resolves the Post model matching the provided
{post}
ID or returns a 404 if not found. For this reason, receiving and validatingpost_id
in theFormRequest
for these routes is redundant.This PR removes the generation of form requests validation rules for columns named after the controller
meta.parent
plus the_id
suffix (e.g.,post_id
).Before and after
Validation Rules Before:
Validation Rules After:
Testing
This PR includes a test to verify the generated form request for a controller with a parent. All existing tests remain unchanged and are passing, ensuring form requests are correctly generated in all other scenarios.