Merge pull request #4 from lassodatasystems/remove-oauth2-bundle-chec…

…kstyle-violations

Remove Oauth2ClientBundle checkstyle violations

Client.php

@@ -18,6 +18,7 @@
  * Buzz\Browser to get auto-completion on all available methods.
  *
  * Class Client
+ *
  * @package Lasso\Oauth2ClientBundle
  */
 class Client
@@ -45,7 +46,7 @@ public function __construct(Token $token, Browser $browser)
     /**
      * Adds authorization token to headers using bearer method
      *
-     * @param $headers
+     * @param array $headers
      *
      * @return array
      */
@@ -75,10 +76,10 @@ protected function throwExceptionOnResponseError(Response $response)
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
+     * @param string $url
+     * @param array  $headers
      *
-     * @param       $url
-     * @param array $headers
+     * @see Lasso\Oauth2ClientBundle\Client::call
      *
      * @return Response
      */
@@ -88,12 +89,12 @@ public function get($url, $headers = array())
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
-     *
-     * @param        $url
+     * @param string $url
      * @param array  $headers
      * @param string $content
      *
+     * @see Lasso\Oauth2ClientBundle\Client::call
+     *
      * @return Response
      */
     public function post($url, $headers = array(), $content = '')
@@ -102,10 +103,10 @@ public function post($url, $headers = array(), $content = '')
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
+     * @param string $url
+     * @param array  $headers
      *
-     * @param       $url
-     * @param array $headers
+     * @see Lasso\Oauth2ClientBundle\Client::call
      *
      * @return Response
      */
@@ -115,12 +116,12 @@ public function head($url, $headers = array())
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
-     *
-     * @param        $url
+     * @param string $url
      * @param array  $headers
      * @param string $content
      *
+     * @see Lasso\Oauth2ClientBundle\Client::call
+     *
      * @return Response
      */
     public function patch($url, $headers = array(), $content = '')
@@ -129,12 +130,12 @@ public function patch($url, $headers = array(), $content = '')
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
-     *
-     * @param        $url
+     * @param string $url
      * @param array  $headers
      * @param string $content
      *
+     * @see Lasso\Oauth2ClientBundle\Client::call
+     *
      * @return Response
      */
     public function put($url, $headers = array(), $content = '')
@@ -143,12 +144,12 @@ public function put($url, $headers = array(), $content = '')
     }
 
     /**
-     * @see Lasso\Oauth2ClientBundle\Client::call
-     *
-     * @param        $url
+     * @param string $url
      * @param array  $headers
      * @param string $content
      *
+     * @see Lasso\Oauth2ClientBundle\Client::call
+     *
      * @return Response
      */
     public function delete($url, $headers = array(), $content = '')

ClientFactory.php

@@ -6,11 +6,20 @@
 use Lasso\Oauth2ClientBundle\Client;
 use Buzz\Browser;
 
+/**
+ * Class ClientFactory
+ *
+ * @package Lasso\Oauth2ClientBundle
+ */
 class ClientFactory
 {
     protected $tokenFactory;
     protected $browser;
 
+    /**
+     * @param TokenFactory $tokenFactory
+     * @param Browser      $browser
+     */
     public function __construct(
         TokenFactory $tokenFactory,
         Browser $browser
@@ -20,27 +29,45 @@ public function __construct(
         $this->browser      = $browser;
     }
 
+    /**
+     * @param string $clientId
+     *
+     * @return $this
+     */
     public function withClientId($clientId)
     {
         $this->tokenFactory->withClientId($clientId);
 
         return $this;
     }
 
+    /**
+     * @param string $clientSecret
+     *
+     * @return $this
+     */
     public function withClientSecret($clientSecret)
     {
         $this->tokenFactory->withClientSecret($clientSecret);
 
         return $this;
     }
 
+    /**
+     * @param string $tokenUrl
+     *
+     * @return $this
+     */
     public function withTokenUrl($tokenUrl)
     {
         $this->tokenFactory->withTokenUrl($tokenUrl);
 
         return $this;
     }
 
+    /**
+     * Reset
+     */
     public function reset()
     {
         $this->tokenFactory->reset();

DependencyInjection/LassoOauth2ClientExtension.php

@@ -22,8 +22,7 @@ public function load(array $configs, ContainerBuilder $container)
         $configuration = new Configuration();
         $config        = $this->processConfiguration($configuration, $configs);
 
-        $parameterBag = $container->getParameterBag();
-        foreach($config as $key => $value) {
+        foreach ($config as $key => $value) {
             $container->setParameter(
                 'lasso_oauth2.' . $key,
                 $container->getParameterBag()->resolveValue($value)

Exceptions/ClientErrorException.php

@@ -6,6 +6,10 @@
  * Thrown if the response status code is 4xx
  *
  * Class ClientErrorException
+ *
  * @package Lasso\Oauth2ClientBundle\Exceptions
  */
-class ClientErrorException extends HttpStatusCodeException {}
+class ClientErrorException extends HttpStatusCodeException
+{
+
+}

Exceptions/HttpStatusCodeException.php

@@ -7,6 +7,7 @@
 
 /**
  * Class HttpStatusCodeException
+ *
  * @package Lasso\Oauth2ClientBundle\Exceptions
  */
 abstract class HttpStatusCodeException extends Exception

Exceptions/ServerErrorException.php

@@ -6,6 +6,10 @@
  * Thrown if response status code is 5xx
  *
  * Class ServerErrorException
+ *
  * @package Lasso\Oauth2ClientBundle\Exceptions
  */
-class ServerErrorException extends HttpStatusCodeException {}
+class ServerErrorException extends HttpStatusCodeException
+{
+
+}

Tests/Unit/ClientFactoryTest.php

@@ -5,6 +5,11 @@
 use PHPUnit_Framework_TestCase;
 use PHPUnit_Framework_MockObject_MockObject;
 
+/**
+ * Class ClientFactoryTest
+ *
+ * @package Lasso\Oauth2ClientBundle\Tests
+ */
 class ClientFactoryTest extends PHPUnit_Framework_TestCase
 {
     /**

Tests/Unit/ClientTest.php

@@ -7,6 +7,11 @@
 use Lasso\Oauth2ClientBundle\Exceptions\ServerErrorException;
 use PHPUnit_Framework_TestCase;
 
+/**
+ * Class ClientTest
+ *
+ * @package Lasso\Oauth2ClientBundle\Tests\Unit
+ */
 class ClientTest extends PHPUnit_Framework_TestCase
 {
     protected $token;

Tests/Unit/TokenFactoryTest.php

@@ -8,6 +8,11 @@
 use PHPUnit_Framework_MockObject_MockObject;
 use StdClass;
 
+/**
+ * Class TokenFactoryTest
+ *
+ * @package Lasso\Oauth2ClientBundle\Tests
+ */
 class TokenFactoryTest extends PHPUnit_Framework_TestCase
 {
     /**

Tests/Unit/TokenTest.php

@@ -6,6 +6,11 @@
 
 require dirname(__FILE__) . '/../../Token.php';
 
+/**
+ * Class TokenTest
+ *
+ * @package Lasso\Oauth2ClientBundle
+ */
 class TokenTest extends PHPUnit_Framework_TestCase
 {
     /**

Token.php

@@ -5,6 +5,7 @@
 
 /**
  * Class Token
+ *
  * @package Lasso\Oauth2ClientBundle
  */
 class Token
@@ -52,7 +53,6 @@ public function __construct($clientId,
     }
 
     /**
-     *
      * @return string
      */
     protected function acquireToken()

TokenFactory.php

@@ -5,6 +5,11 @@
 use Buzz\Browser;
 use StdClass;
 
+/**
+ * Class TokenFactory
+ *
+ * @package Lasso\Oauth2ClientBundle
+ */
 class TokenFactory
 {
     /**
@@ -24,6 +29,12 @@ class TokenFactory
     protected $tokenConfig;
     protected $browser;
 
+    /**
+     * @param string  $clientId
+     * @param string  $clientSecret
+     * @param string  $tokenUrl
+     * @param Browser $browser
+     */
     public function __construct(
         $clientId,
         $clientSecret,
@@ -40,32 +51,53 @@ public function __construct(
         $this->tokenConfig = clone $this->originalTokenConfig;
     }
 
+    /**
+     * @param string $clientId
+     *
+     * @return $this
+     */
     public function withClientId($clientId)
     {
         $this->tokenConfig->clientId = $clientId;
 
         return $this;
     }
 
+    /**
+     * @param string $clientSecret
+     *
+     * @return $this
+     */
     public function withClientSecret($clientSecret)
     {
         $this->tokenConfig->clientSecret = $clientSecret;
 
         return $this;
     }
 
+    /**
+     * @param string $tokenUrl
+     *
+     * @return $this
+     */
     public function withTokenUrl($tokenUrl)
     {
         $this->tokenConfig->tokenUrl = $tokenUrl;
 
         return $this;
     }
 
+    /**
+     * Reset
+     */
     public function reset()
     {
         $this->tokenConfig = clone $this->originalTokenConfig;
     }
 
+    /**
+     * @return Token
+     */
     public function create()
     {
         $token = new Token(