Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bramses
reported this bug first in #8.Recreation
Explanation
The
bpe()
method of the encoder uses a cache like so:But
in
has some unexpected behavior:So calling
this.bpe("toString")
returns the functionObject.prototype.toString
. This causes an error.Fix
I changed the implementation to use a JS
Map
, which is a better cache data structure that avoids this bug.