Correct swapped input/output and add error handling

lausser · Dec 20, 2024 · 7a2c387 · 7a2c387
1 parent 7fd8b69
commit 7a2c387
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/plugins-scripts/CheckNwcHealth/IFMIB/Component/InterfaceSubsystem.pm b/plugins-scripts/CheckNwcHealth/IFMIB/Component/InterfaceSubsystem.pm
@@ -1184,11 +1184,11 @@ sub check {
     });
     my $coutwarning = $self->mod_threshold($outwarning, sub {
         my $val = shift;
-        return $self->{maxInputRate} / 100 * $val;
+        return $self->{maxOutputRate} / 100 * $val;
     });
     my $coutcritical = $self->mod_threshold($outcritical, sub {
         my $val = shift;
-        return $self->{maxInputRate} / 100 * $val;
+        return $self->{maxOutputRate} / 100 * $val;
     });
     $self->set_thresholds(
         # it there are --warning/critical on the command line
@@ -1294,16 +1294,16 @@ sub check {
         value => $self->{inputRate},
         uom => $self->opts->units =~ /^(B|KB|MB|GB|TB)$/ ? $self->opts->units : undef,
         places => 2,
-        min => 0,
-        max => $self->{maxInputRate},
+        min => $self->{maxInputRate} ? 0 : "",
+        max => $self->{maxInputRate} ? $self->{maxInputRate} : "",
     );
     $self->add_perfdata(
         label => $self->{ifDescr}.'_traffic_out',
         value => $self->{outputRate},
         uom => $self->opts->units =~ /^(B|KB|MB|GB|TB)$/ ? $self->opts->units : undef,
         places => 2,
-        min => 0,
-        max => $self->{maxOutputRate},
+        min => $self->{maxOutputRate} ? 0 : "",
+        max => $self->{maxOutputRate} ? $self->{maxOutputRate} : "",
     );
   } elsif ($self->mode =~ /device::interfaces::errors/) {
     $self->add_info(sprintf 'interface %s errors in:%.2f%% out:%.2f%% ',